8338281: jshell does not run shutdown hooks #3595
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
phohensee
reviewed
May 20, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8338281: jshell does not run shutdown hooks. Adjusts logic to now exit the remote agent when receiving the CLOSE event and delays the JShell's close for a moment for the remote process to finish. Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test. Patch is clean.
Progress
Warning
8338281: jshell does not run shutdown hooksIssue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3595/head:pull/3595$ git checkout pull/3595Update a local copy of the PR:
$ git checkout pull/3595$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3595/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3595View PR using the GUI difftool:
$ git pr show -t 3595Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3595.diff
Using Webrev
Link to Webrev Comment